lukecwik commented on pull request #12578: URL: https://github.com/apache/beam/pull/12578#issuecomment-678413620
> > Not sure how much we want to invest in clean-up here since there are data structures which are effective copies and the methods should take an object that represents the computation and key instead of requiring the explicit parameters to be exploded out. We would likely get a good savings on memory usage since we would be passing around a single object in a lot of these places and we would also save some CPU since we aren't creating/destroying the objects all over the place. > > MetricTrackingWindmillServerStub.KeyAndComputation == ReaderCache.CacheKey == WindmillStateCache.ComputationKey > > There are some other types which are sub/super types of the one above. > > Sounds good to deduplicate. Would it make sense to have a separate PR for clean-up? Yes, a separate PR sounds best. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
