chamikaramj commented on code in PR #31106:
URL: https://github.com/apache/beam/pull/31106#discussion_r1594322815
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java:
##########
@@ -52,16 +52,18 @@
/** This {@link PTransform} manages loads into BigQuery using the Storage API.
*/
public class StorageApiLoads<DestinationT, ElementT>
extends PTransform<PCollection<KV<DestinationT, ElementT>>, WriteResult> {
- final TupleTag<KV<DestinationT, StorageApiWritePayload>>
successfulConvertedRowsTag =
- new TupleTag<>("successfulRows");
+ final TupleTag<KV<DestinationT, KV<ElementT, StorageApiWritePayload>>>
Review Comment:
I think one way to do that might be to use schema'd `PCollection`s
everywhere and evolve the schema when we want to do changes to the
`PCollection` structure. But for the time being we have to fork the code to
preserve compatibility. BTW not all structure changes will break compatibility
so some changes can be done without forking (Dataflow link above has some
details) but generally coder changes can break update compatibility (and
probably Dataflow compatibility check will fail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
