Abacn commented on PR #31117:
URL: https://github.com/apache/beam/pull/31117#issuecomment-2101268832
thanks for the fix. While this sounds a valid fix, would you mind sharing
the full stack trace. My understanding here is that there are two issues
(1) Beam SQL does not filter out fields not used
(2) Iterable isn't supported by Beam SQL
A full stack will be helpful to investigate (1), and possible optimization
The Iterable field type, introduced in #10003 was meant to be different than
ARRAY. However the fix here treats it the same as ARRAY. It may have
performance implications, and not work for large iterables? Maybe add a comment
here or a TODO.
until it's optimized for Iterable, one can just write
```
case ARRAY:
case ITERABLE:
return ....
```
so no need duplicate the line.
Also, there are switch (fieldType.getTypeName()) branches in several places
in BeamCalRel, could it be all fixed for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
