RyuSA commented on issue #31218:
URL: https://github.com/apache/beam/issues/31218#issuecomment-2102782048
@Abacn Thank you for reviewing my proposal. 👍
> #31219 will cause excessive warning raised if user not intended to install
these dependencies...
In my PR, there should not be any warning logs for modules ([gcp], [aws],
etc.) that the user has not intended to installed. The import statement for
not-installed modules should throw `ModuleNotFoundError`, so they should be
blocked before the section on `ImportError`. (Am I right?)
```
$ python3
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> try:
... import this_is_module_not_found
... except ModuleNotFoundError:
... print("ModuleNotFound!")
... except ImportError:
... print("ImportError!")
...
ModuleNotFound!
>>>
```
However, on the other hand:
> Can we improve the error message you referred to in the description
instead?
> Even better, currently it hints ...
I think these ideas are excellent!
I was considering this issue under the scope of "when modules
(gcp/aws/azure) installed by the user as Filesystem fail to initialize due to
for some reason (such as OpenSSL)."
I think the enhancement you suggested(where the user has not installed
Filesystem) could either be a separate issue or included in this one. (I would
be happy to submit a PR! 👀)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
