RyuSA commented on code in PR #31219: URL: https://github.com/apache/beam/pull/31219#discussion_r1595548922
########## sdks/python/apache_beam/io/filesystems.py: ########## @@ -35,28 +38,38 @@ # pylint: disable=wrong-import-position, unused-import try: from apache_beam.io.hadoopfilesystem import HadoopFileSystem -except ImportError: +except ModuleNotFoundError: Review Comment: Well, of course, when `apache_beam.io.hadoopfilesystem.HadoopFileSystem` is not installed... Wait, the Filesystem is under `apache_beam.io`, so the module is embedded by default Apache Beam?? If so `LocalFileSystem` below should also be installed by default, so this kind of handling would be unnecessary. Just to confirm, I would like a Yes/No answer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
