leiyiz commented on a change in pull request #12580:
URL: https://github.com/apache/beam/pull/12580#discussion_r474853441
##########
File path:
sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_launcher.py
##########
@@ -262,13 +285,13 @@ def run(self):
query_duration =
self.pipeline_options.view_as(TestOptions).wait_until_finish_duration #
pylint: disable=line-too-long
if launch_from_direct_runner:
command = Command(
- self.run_query, args=[queries[i], query_args.get(i), query_errors])
+ self.run_query, args=[queries[i], query_args, query_errors])
command.run(timeout=query_duration // 1000)
else:
try:
- self.run_query(queries[i], query_args.get(i), query_errors=None)
+ self.run_query(queries[i], query_args, query_errors=query_errors)
Review comment:
because a lot of queries actually want the same arg options and because
we are doing dict lookup inside the queries anyway due to more than 1 query
args, I just removed the per-query args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
