m-trieu commented on code in PR #31133:
URL: https://github.com/apache/beam/pull/31133#discussion_r1599125929
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationStateCacheTest.java:
##########
@@ -218,32 +241,46 @@ public void testGetAllComputations() {
@Test
public void testTotalCurrentActiveGetWorkBudget() {
String computationId = "computationId";
+ String computationId2 = "computationId2";
MapTask mapTask = new
MapTask().setStageName("stageName").setSystemName("systemName");
Map<String, String> userTransformToStateFamilyName =
ImmutableMap.of("userTransformName", "stateFamilyName");
ComputationConfig computationConfig =
ComputationConfig.create(mapTask, userTransformToStateFamilyName,
ImmutableMap.of());
when(configFetcher.fetchConfig(eq(computationId))).thenReturn(Optional.of(computationConfig));
+
when(configFetcher.fetchConfig(eq(computationId2))).thenReturn(Optional.of(computationConfig));
+ Work work1 = createWork(1, 1);
+ Work work2 = createWork(2, 2);
+ Work work3 = createWork(3, 3);
+
+ // Activate 3 Work(s) for computationId
Optional<ComputationState> maybeComputationState =
computationStateCache.get(computationId);
assertTrue(maybeComputationState.isPresent());
-
ComputationState computationState = maybeComputationState.get();
ShardedKey shardedKey = ShardedKey.create(ByteString.EMPTY, 1);
- Work work1 = createWork(1, 1);
- Work work2 = createWork(2, 2);
- Work work3 = createWork(3, 3);
computationState.activateWork(shardedKey, work1);
computationState.activateWork(shardedKey, work2);
computationState.activateWork(shardedKey, work3);
+ // Activate 3 Work(s) for computationId2
+ Optional<ComputationState> maybeComputationState2 =
computationStateCache.get(computationId);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
