riteshghorse commented on code in PR #31295:
URL: https://github.com/apache/beam/pull/31295#discussion_r1605243576
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py:
##########
@@ -157,10 +157,11 @@ def __init__(
(self.select_fields, self.table_name, self.row_restriction_template))
self.kwargs = kwargs
self._batching_kwargs = {}
- if min_batch_size is not None:
- self._batching_kwargs['min_batch_size'] = min_batch_size
- if max_batch_size is not None:
- self._batching_kwargs['max_batch_size'] = max_batch_size
+ if not query_fn:
Review Comment:
yes for query construction parameters. It doesn't validate batch size but
its okay I think. There is a clear note in documentation to not do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
