damondouglas commented on PR #31323: URL: https://github.com/apache/beam/pull/31323#issuecomment-2119001599
> Can we add or update existing tests in [StorageApiSinkRowUpdateIT](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkRowUpdateIT.java)? That class contains integration tests for RowMutationInformation. Would be good to have some real end-to-end tests to check this new behavior @ahmedabu98 that test already covers the refactor behavior. For example, there's a call to `RowMutationInformation.of` using a long value. This is forwarded to the `RowMutationInformation.of` that takes the string parameter set using `Long.toHexString`. Adding additional tests using the string parameter directly would just test implementation details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
