Abacn commented on code in PR #31344:
URL: https://github.com/apache/beam/pull/31344#discussion_r1607312535
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -141,6 +143,43 @@ def test_batch_copy_and_delete(self):
self.assertFalse(
result[1], 're-delete should not throw error: %s' % result[1])
+ @pytest.mark.it_postcommit
+ @mock.patch('apache_beam.io.gcp.gcsio.default_gcs_bucket_name')
Review Comment:
it doesn't sounds quite right that a PostCommit needs a mock. And this mock
isn't mock a fake service, it's used to override nomenclature of temp bucket.
What happens if we do not hack it?
Also, this test does not run a pipeline, should we configure it only run on
test-suites:direct:py3xx:postCommitIT. Persumably currently it is running on
Dataflow PostCommit IT suites which is not quite right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
