clairemcginty commented on PR #31025: URL: https://github.com/apache/beam/pull/31025#issuecomment-2125485570
> Thanks for the review @damondouglas ! Sorry for the late reply, I've been out of office, but will apply these suggestions today or tomorrow 👍 Updated! your suggestions are much clearer -- my original approach constructed the custom functions up-front so that we wouldn't have to do the type-checking on every individual element, but I think the readability/clarity was just not worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
