pskevin commented on a change in pull request #12667:
URL: https://github.com/apache/beam/pull/12667#discussion_r475027909
##########
File path: sdks/go/pkg/beam/core/graph/xlang.go
##########
@@ -71,8 +93,10 @@ func (ext ExternalTransform) WithNamedOutputs(outputsMap
map[string]int) Externa
return ext
}
-// TODO(pskevin): Credit one of the best stackoverflow answers @
https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-go
-
+// NewNamespaceGenerator returns a functions that generates a random string of
n alphabets
+//
+// Adopted from icza's stackoverflow answer @
+//
https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-go
Review comment:
Ack. Updated!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
