m-trieu commented on code in PR #31317: URL: https://github.com/apache/beam/pull/31317#discussion_r1613894213
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java: ########## @@ -193,31 +180,33 @@ public void start( for (StepContext stepContext : stepContexts) { stepContext.start( stateReader, - inputDataWatermark, + work.watermarks().inputDataWatermark(), Review Comment: done added TODO, will probably update all usage where `Instant inputDataWatermark, Instant outputDatamark, Instant synchronizedProcessingTime` are used together with `Work.Watermarks`. Since this is the case will move `Watermarks` outside of Work.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org