lostluck commented on code in PR #30492:
URL: https://github.com/apache/beam/pull/30492#discussion_r1618120893
##########
sdks/go/pkg/beam/runners/prism/internal/engine/engine_test.go:
##########
@@ -221,3 +221,46 @@ func TestTestStream(t *testing.T) {
}
}
}
+
+// TestProcessingTime is the suite for validating behaviors around
ProcessingTime.
+// Separate from the TestStream, Timers, and Triggers tests due to the unique
nature
+// of the time domain.
+func TestProcessingTime(t *testing.T) {
+ initRunner(t)
+
+ tests := []struct {
+ pipeline func(s beam.Scope)
+ }{
+ {pipeline: primitives.TimersProcessingTimeTestStream_Infinity},
+ {pipeline: primitives.TimersProcessingTime_Bounded},
+ {pipeline: primitives.TimersProcessingTime_Unbounded},
+ }
+
+ configs := []struct {
+ name string
+ OneElementPerKey, OneKeyPerBundle bool
+ }{
+ {"Greedy", false, false},
+ {"AllElementsPerKey", false, true},
+ {"OneElementPerKey", true, false},
+ // {"OneElementPerBundle", true, true}, // Reveals flaky
behavior
Review Comment:
I had not observed that specific behavior (the key not being in the logs in
an earlier part of the same call). Very interesting. The latter log is designed
to catch that specific flake a bit more clearly than the downstream handling.
We'll get it! I believe in us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
