Polber commented on code in PR #31374:
URL: https://github.com/apache/beam/pull/31374#discussion_r1618157995
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -30,14 +30,14 @@
mappings:
'ReadFromBigQuery':
query: 'query'
- table: 'tableSpec'
- fields: 'selectedFields'
- row_restriction: 'rowRestriction'
+ table: 'table_spec'
+ fields: 'selected_fields'
+ row_restriction: 'row_restriction'
'WriteToBigQuery':
table: 'table'
- create_disposition: 'createDisposition'
- write_disposition: 'writeDisposition'
- error_handling: 'errorHandling'
+ create_disposition: 'create_disposition'
+ write_disposition: 'write_disposition'
+ error_handling: 'error_handling'
# TODO(https://github.com/apache/beam/issues/30058): Required until
autosharding support is fixed
num_streams: 'numStreams'
Review Comment:
```suggestion
num_streams: 'num_streams'
```
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -206,25 +206,25 @@
mappings:
'ReadFromJdbc':
driver_class_name: 'driverClassName'
Review Comment:
```suggestion
driver_class_name: 'driver_class_name'
```
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
Review Comment:
Also need modifications in
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/yaml/standard_providers.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
