m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1619440742
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkStateTest.java:
##########
@@ -53,38 +60,69 @@ public class ActiveWorkStateTest {
private final WindmillStateCache.ForComputation computationStateCache =
mock(WindmillStateCache.ForComputation.class);
@Rule public transient Timeout globalTimeout = Timeout.seconds(600);
- private Map<ShardedKey, Deque<Work>> readOnlyActiveWork;
+ private Map<ShardedKey, Deque<ExecutableWork>> readOnlyActiveWork;
private ActiveWorkState activeWorkState;
private static ShardedKey shardedKey(String str, long shardKey) {
return ShardedKey.create(ByteString.copyFromUtf8(str), shardKey);
}
- private static Work createWork(Windmill.WorkItem workItem) {
- return Work.create(workItem, Instant::now, Collections.emptyList(), unused
-> {});
+ private static ExecutableWork createWork(Windmill.WorkItem workItem) {
+ WorkCommitter workCommitter = mock(WorkCommitter.class);
+ doNothing().when(workCommitter).commit(any(Commit.class));
+ WindmillStream.GetDataStream getDataStream =
mock(WindmillStream.GetDataStream.class);
+ when(getDataStream.requestKeyedData(anyString(), any()))
+ .thenReturn(Windmill.KeyedGetDataResponse.getDefaultInstance());
Review Comment:
removed
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkStateTest.java:
##########
@@ -53,38 +60,69 @@ public class ActiveWorkStateTest {
private final WindmillStateCache.ForComputation computationStateCache =
mock(WindmillStateCache.ForComputation.class);
@Rule public transient Timeout globalTimeout = Timeout.seconds(600);
- private Map<ShardedKey, Deque<Work>> readOnlyActiveWork;
+ private Map<ShardedKey, Deque<ExecutableWork>> readOnlyActiveWork;
private ActiveWorkState activeWorkState;
private static ShardedKey shardedKey(String str, long shardKey) {
return ShardedKey.create(ByteString.copyFromUtf8(str), shardKey);
}
- private static Work createWork(Windmill.WorkItem workItem) {
- return Work.create(workItem, Instant::now, Collections.emptyList(), unused
-> {});
+ private static ExecutableWork createWork(Windmill.WorkItem workItem) {
+ WorkCommitter workCommitter = mock(WorkCommitter.class);
+ doNothing().when(workCommitter).commit(any(Commit.class));
+ WindmillStream.GetDataStream getDataStream =
mock(WindmillStream.GetDataStream.class);
+ when(getDataStream.requestKeyedData(anyString(), any()))
+ .thenReturn(Windmill.KeyedGetDataResponse.getDefaultInstance());
+ return ExecutableWork.create(
+ Work.create(
+ workItem,
+ Watermarks.builder().setInputDataWatermark(Instant.EPOCH).build(),
+ createWorkProcessingContext(),
+ Instant::now,
+ Collections.emptyList()),
+ ignored -> {});
}
- private static Work expiredWork(Windmill.WorkItem workItem) {
- return Work.create(workItem, () -> Instant.EPOCH, Collections.emptyList(),
unused -> {});
+ private static ExecutableWork expiredWork(Windmill.WorkItem workItem) {
+ return ExecutableWork.create(
+ Work.create(
+ workItem,
+ Watermarks.builder().setInputDataWatermark(Instant.EPOCH).build(),
+ createWorkProcessingContext(),
+ () -> Instant.EPOCH,
+ Collections.emptyList()),
+ ignored -> {});
+ }
+
+ private static Work.ProcessingContext createWorkProcessingContext() {
+ WorkCommitter workCommitter = mock(WorkCommitter.class);
+ doNothing().when(workCommitter).commit(any(Commit.class));
+ WindmillStream.GetDataStream getDataStream =
mock(WindmillStream.GetDataStream.class);
+ when(getDataStream.requestKeyedData(anyString(), any()))
+ .thenReturn(Windmill.KeyedGetDataResponse.getDefaultInstance());
+ return Work.createProcessingContext("computationId",
getDataStream::requestKeyedData)
+ .setWorkCommitter(workCommitter::commit)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
