robertwb commented on code in PR #31363:
URL: https://github.com/apache/beam/pull/31363#discussion_r1621195522
##########
sdks/python/apache_beam/runners/worker/data_plane.py:
##########
@@ -129,15 +128,19 @@ def create(
class SizeBasedBufferingClosableOutputStream(ClosableOutputStream):
"""A size-based buffering OutputStream."""
+ _large_flush_last_observed_timestamp = 0.0
+
def __init__(
self,
close_callback=None, # type: Optional[Callable[[bytes], None]]
flush_callback=None, # type: Optional[Callable[[bytes], None]]
- size_flush_threshold=_DEFAULT_SIZE_FLUSH_THRESHOLD # type: int
+ size_flush_threshold=_DEFAULT_SIZE_FLUSH_THRESHOLD, # type: int
+ large_buffer_warn_threshold_mib = 512 # type: int
Review Comment:
nit: I'd just let this be in bytes (for consistency with everything else)
rather than have `_mib` and do the conversion elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
