ahmedabu98 commented on code in PR #31470:
URL: https://github.com/apache/beam/pull/31470#discussion_r1625082136
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java:
##########
@@ -194,7 +199,28 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
SchemaTransform underlyingTransform =
new
ManagedSchemaTransformProvider(getSupportedIdentifiers()).from(managedConfig);
- return input.apply(underlyingTransform);
+ return inputTuple.apply(underlyingTransform);
+ }
+
+ @VisibleForTesting
+ static PCollectionRowTuple resolveInput(PInput input) {
Review Comment:
PCollectionRowTuple already implements apply() for
PTransform<PCollectionRowTuple, OutputT>:
https://github.com/apache/beam/blob/4ad7037b55f4b711a67f3f2170bc8661a9b799b5/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionRowTuple.java#L196-L199
Java doesn't let us define the same method with a different generic (e.g.
PTransform<PCollection<Row>, OutputT>) because they will ultimately have the
same erasure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
