je-ik commented on PR #29793: URL: https://github.com/apache/beam/pull/29793#issuecomment-2151757415
There was a significant change in https://github.com/apache/beam/pull/25525 that affects this. The `ReaderInvocationUtil#invokeCheckpoint` must be used in `FlinkUnboundedSourceReader#getReaderCheckpoint` as well. For this functionality to be preserved during refactorings, it would be nice to add at least a basic test to verify it works (which would prove it will not - at least for classic runner - in this case, because of the missing use in `FlinkUnboundedSourceReader`. The `UnboudedSourceWrapper` should be removed as drafted in https://github.com/apache/beam/pull/31530. In the original PR there was a suspicion that this causes [some issues][1], is this resolved? [1]: https://github.com/apache/beam/pull/25554#issuecomment-1460892717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
