bzablocki commented on PR #31476: URL: https://github.com/apache/beam/pull/31476#issuecomment-2151864333
Hi @damondouglas , thanks for the comment and suggestions. I totally get where this comes from. While I'd really like to split it into smaller PRs, this might be difficult as components like CheckpointMark, UnboundedReader, UnboundedSource, WatermarkParameters/Policy, Authentication classes, data classes have to go together, in one PR. What I can think of is: - moving test to a separate PR, but I don't think this is a good idea. - removing some of the configuration options from the main SolaceIO file, but this will only slightly decrease the size of the SolaceIO.java file. So, unfortunately, I think we have to go with option 2. and just accept it might take a little bit longer. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
