ahmedabu98 commented on code in PR #31537:
URL: https://github.com/apache/beam/pull/31537#discussion_r1633559155
##########
sdks/python/apache_beam/yaml/yaml_io.py:
##########
@@ -114,12 +131,43 @@ def read_from_bigquery(
def write_to_bigquery(
- table,
+ table: Optional[str],
*,
- create_disposition=BigQueryDisposition.CREATE_IF_NEEDED,
- write_disposition=BigQueryDisposition.WRITE_APPEND,
+ create_disposition: str = BigQueryDisposition.CREATE_IF_NEEDED,
+ write_disposition: str = BigQueryDisposition.WRITE_APPEND,
Review Comment:
```suggestion
create_disposition: Optional[str] = BigQueryDisposition.CREATE_IF_NEEDED,
write_disposition: Optional[str] = BigQueryDisposition.WRITE_APPEND,
```
##########
sdks/python/apache_beam/yaml/yaml_io.py:
##########
@@ -114,12 +131,43 @@ def read_from_bigquery(
def write_to_bigquery(
- table,
+ table: Optional[str],
Review Comment:
```suggestion
table: str,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
