shunping commented on code in PR #31466:
URL: https://github.com/apache/beam/pull/31466#discussion_r1634853392
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -900,6 +900,17 @@ def _add_argparse_args(cls, parser):
'Controls the OAuth scopes that will be requested when creating '
'GCP credentials. Note: If set programmatically, must be set as a '
'list of strings'))
+ parser.add_argument(
Review Comment:
Can we also add a default value for the new arguments?
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -900,6 +900,17 @@ def _add_argparse_args(cls, parser):
'Controls the OAuth scopes that will be requested when creating '
'GCP credentials. Note: If set programmatically, must be set as a '
'list of strings'))
+ parser.add_argument(
+ '--enable_bucket_read_metric_counter',
+ action='store_true',
+ help='Create metrics reporting the approximate number of bytes read '
+ 'per bucket.')
+ parser.add_argument(
Review Comment:
Same as the previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
