lostluck commented on code in PR #31567: URL: https://github.com/apache/beam/pull/31567#discussion_r1635414927
########## sdks/go.mod: ########## @@ -20,7 +20,7 @@ // directory. module github.com/apache/beam/sdks/v2 -go 1.20 +go 1.21 Review Comment: While I *don't* think it'll be a problem to do it as a rule, there's just other work that might be good to do when bumping the minimum version as well, and that's very out of scope of this PR. Basically, bumping the minimum version is a *huge* change just to avoid a single if statement, compared to writing the conditional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
