shunping commented on code in PR #31576:
URL: https://github.com/apache/beam/pull/31576#discussion_r1636889333
##########
sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIOTest.java:
##########
@@ -391,22 +391,22 @@ public void testArrayOfPrimitiveTypes() throws Exception {
try (ResultSet rs = executeQuery("SELECT * FROM
test_array_of_primitive_types")) {
rs.next();
- assertEquals("['2030-10-01','2031-10-01']", rs.getString("f0"));
- assertEquals("['2030-10-09 08:07:06','2031-10-09 08:07:06']",
rs.getString("f1"));
- assertEquals("[2.2,3.3]", rs.getString("f2"));
- assertEquals("[3.3,4.4]", rs.getString("f3"));
- assertEquals("[4,5]", rs.getString("f4"));
- assertEquals("[5,6]", rs.getString("f5"));
- assertEquals("[6,7]", rs.getString("f6"));
- assertEquals("[7,8]", rs.getString("f7"));
- assertEquals("['eight','nine']", rs.getString("f8"));
- assertEquals("[9,10]", rs.getString("f9"));
- assertEquals("[10,11]", rs.getString("f10"));
- assertEquals("[11,12]", rs.getString("f11"));
- assertEquals("[12,13]", rs.getString("f12"));
- assertEquals("['abc','cde']", rs.getString("f13"));
- assertEquals("['cde','abc']", rs.getString("f14"));
- assertEquals("[true,false]", rs.getString("f15"));
+ assertEquals("[2030-10-01, 2031-10-01]", rs.getString("f0"));
Review Comment:
Looks like all the string fields no longer have single quotes around them.
Is that the breaking change introduced by the clickhouse-server version upgrade?
##########
sdks/java/io/clickhouse/build.gradle:
##########
@@ -66,7 +66,6 @@ dependencies {
testImplementation library.java.testcontainers_clickhouse
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
- testImplementation project(path: ":sdks:java:extensions:avro",
configuration: "testRuntimeMigration")
Review Comment:
unused dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
