kmjung commented on a change in pull request #12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r476580093
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference
ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return
builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
Review comment:
Done.
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference
ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return
builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
}
- @VisibleForTesting
- static TableReference toTableRef(TableReferenceProto.TableReference ref) {
- return new TableReference()
- .setProjectId(ref.getProjectId())
- .setDatasetId(ref.getDatasetId())
- .setTableId(ref.getTableId());
+ static String toTableResourceName(TableReference tableReference) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
