Abacn commented on code in PR #31600:
URL: https://github.com/apache/beam/pull/31600#discussion_r1640059375
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -816,6 +821,13 @@ public static FieldType iterable(FieldType elementType) {
/** Create a map type for the given key and value types. */
public static FieldType map(FieldType keyType, FieldType valueType) {
+ if (FieldType.BYTES.equals(keyType)) {
Review Comment:
This is a valid warning, however may cause log spam as the code path is
visited on every value.
A Possible solution is to have a private static flag to track if the warning
has been emitted so emit this error once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
