ahmedabu98 commented on code in PR #31608:
URL: https://github.com/apache/beam/pull/31608#discussion_r1641217868
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java:
##########
@@ -1487,8 +1506,12 @@ public PDone expand(PCollection<T> input) {
pubsubMessageTuple
.get(BAD_RECORD_TAG)
.setCoder(BadRecord.getCoder(input.getPipeline())));
- PCollection<PubsubMessage> pubsubMessages =
- pubsubMessageTuple.get(pubsubMessageTupleTag).setCoder(new
PubsubMessageWithTopicCoder());
+ PCollection<PubsubMessage> pubsubMessages =
pubsubMessageTuple.get(pubsubMessageTupleTag);
+ if (getNeedsOrderingKey()) {
+ pubsubMessages.setCoder(PubsubMessageSchemaCoder.getSchemaCoder());
+ } else {
+ pubsubMessages.setCoder(new PubsubMessageWithTopicCoder());
+ }
Review Comment:
This fork is required to not break update compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
