damccorm commented on code in PR #31141: URL: https://github.com/apache/beam/pull/31141#discussion_r1642793411
########## sdks/python/apache_beam/options/pipeline_options.py: ########## @@ -81,6 +81,11 @@ def _f(value): return _f +def get_all_subclasses(cls): + """Returns all subclasses of a class, recursively.""" + return set(cls.__subclasses__()).union( + [s for c in cls.__subclasses__() for s in get_all_subclasses(c)]) Review Comment: It looks like this is causing a bunch of test failures because its not correctly deduping items and it considers the current class multiple times. I'm guessing the set comparison isn't working correctly. Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
