Abacn commented on code in PR #31601:
URL: https://github.com/apache/beam/pull/31601#discussion_r1642983499
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -717,6 +738,7 @@ RestClient createClient() throws IOException {
Header[] headerList = new Header[getDefaultHeaders().size()];
restClientBuilder.setDefaultHeaders(getDefaultHeaders().toArray(headerList));
}
+ restClientBuilder.setCompressionEnabled(isCompressionEnabled());
Review Comment:
I am thinking about whether we need to put `setCompressionEnabled`
invocation in a branch in case user is still on old version of elasticsearch
client
```
if (isCompressionEnabled()) {
restClientBuilder.setCompressionEnabled(true);
}
```
##########
sdks/java/io/elasticsearch-tests/elasticsearch-tests-7/build.gradle:
##########
@@ -27,7 +27,7 @@ enableJavaPerformanceTesting()
description = "Apache Beam :: SDKs :: Java :: IO :: Elasticsearch-Tests :: 7.x"
ext.summary = "Tests of ElasticsearchIO on Elasticsearch 7.x"
-def elastic_search_version = "7.13.4"
+def elastic_search_version = "7.17.22"
Review Comment:
The current change should make elasticsearch-test-5 and 6 to fail, however
it is not the case, and I found the elasticsearch compatibility tests never
configured to use intended client version, e.g.
```
+--- org.elasticsearch.client:elasticsearch-rest-client:6.4.0 -> 7.9.2 (*)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
