robertwb commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r476694605
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -540,6 +549,8 @@ def add_parent(child, parent):
transform_id = unique_name(components.transforms, stage.name)
components.transforms[transform_id].CopyFrom(transform)
add_parent(transform_id, stage.parent)
+ if partial:
+ copy_subtransforms(transform)
Review comment:
Nit: You can move this up into the `if partial` block above.
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -1475,6 +1482,12 @@ def only_element(iterable):
return element
+def only_transform(stage):
+ # type: Stage -> beam_runner_api_pb2.PTransform
Review comment:
14:14:31
apache_beam/runners/portability/fn_api_runner/translations.py:1485: error:
syntax error in type comment 'Stage -> beam_runner_api_pb2.PTransform' [syntax]
14:14:31 apache_beam/runners/portability/fn_api_runner/translations.py:1485:
note: Suggestion: wrap argument types in parentheses
14:14:31 Found 1 error in 1 file (checked 719 source files)
14:14:31 error: mypy exited with status 2
14:14:32 ERROR: InvocationError for command
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_PythonLint_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-mypy/py37-mypy/bin/python
setup.py mypy (exited with code 1)
14:14:32 py37-mypy run-test-post: commands[0] | bash
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_PythonLint_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/scripts/run_tox_cleanup.sh
14:14:32 ___________________________________ summary
____________________________________
14:14:32 ERROR: py37-mypy: commands failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
