Abacn commented on code in PR #31639:
URL: https://github.com/apache/beam/pull/31639#discussion_r1645186949
##########
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOITCommon.java:
##########
@@ -34,6 +34,7 @@
* <p>This is independent from the tests so that for read tests it can be run
separately after data
* store creation rather than every time (which can be more fragile.)
*/
+@SuppressWarnings("nullness")
Review Comment:
these test fixtures belong to main scope, and there is a backlog task
eliminate "testRuntimeMigration" (#16307)
##########
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOITCommon.java:
##########
@@ -34,6 +34,7 @@
* <p>This is independent from the tests so that for read tests it can be run
separately after data
* store creation rather than every time (which can be more fragile.)
*/
+@SuppressWarnings("nullness")
Review Comment:
these test fixtures belong to main scope, and there is a backlog task
eliminate "testRuntimeMigration" (#16307).
After moving to main scope checkerframework errors seen. This are test
fixtures so fix is of lower priority and deferred.
##########
.github/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml:
##########
@@ -98,7 +98,6 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: |
- :sdks:java:io:elasticsearch-tests:elasticsearch-tests-5:build \
Review Comment:
Change on github action won't be effective in PR so the ElasticSearch IO
Direct would fail due to target not found.
##########
.github/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml:
##########
@@ -98,7 +98,6 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: |
- :sdks:java:io:elasticsearch-tests:elasticsearch-tests-5:build \
Review Comment:
Change on github action won't be effective in PR so the ElasticSearch IO
Direct would fail due to target not found.
Test on upstream branch running:
https://github.com/apache/beam/pull/31639#discussion_r1645187975
##########
.github/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml:
##########
@@ -98,7 +98,6 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: |
- :sdks:java:io:elasticsearch-tests:elasticsearch-tests-5:build \
Review Comment:
Change on github action won't be effective in PR so the ElasticSearch IO
Direct would fail due to target not found.
Test on upstream branch running:
https://github.com/apache/beam/actions/runs/9573229975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
