Abacn commented on code in PR #31773:
URL: https://github.com/apache/beam/pull/31773#discussion_r1667488350
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java:
##########
@@ -733,7 +733,7 @@ public void testWriteUnboundedWithCustomBatchParameters()
throws Exception {
LINES2_ARRAY,
null,
null,
- 3,
+ 0,
baseFilename,
Review Comment:
I see, then it will no longer assert if the GroupintoBatches works as
intended for those runners currently passing this test. Still think exclude
from SamzaRunner test suite is preferred for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]