nielm commented on PR #31436:
URL: https://github.com/apache/beam/pull/31436#issuecomment-2213338830

   Apologies for slow reply. 
   
   > We should monitor it to make sure we're not running into any GitHub token 
limits, but I don't anticipate that being a problem
   
   This change will not alter the frequency in which PRBot will run, nor the 
actual number of reads of the PRState object (except for the cases where 
notifications are restarted!)
   
   Admittedly the reading/writing of PRstate is a bit inefficient - it could be 
read only once and then cached, and then the write deferred until the end of 
the PRBot run, but I didn't want to dive any deeper into this code!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to