tvalentyn commented on code in PR #31755:
URL: https://github.com/apache/beam/pull/31755#discussion_r1671027483
##########
sdks/python/apache_beam/runners/direct/executor.py:
##########
@@ -84,12 +84,12 @@ def _update_name(self, task=None):
self.name = 'Thread: %d, %s (%s)' % (
self._index, name, 'executing' if task else 'idle')
- def _get_task_or_none(self) -> Optional[_ExecutorService.CallableTask]:
+ def _get_task_or_none(self) -> Optional['_ExecutorService.CallableTask']:
try:
# Do not block indefinitely, otherwise we may not act for a requested
# shutdown.
return self.queue.get(
- timeout=_ExecutorService._ExecutorServiceWorker.TIMEOUT)
+ timeout='_ExecutorService._ExecutorServiceWorker.TIMEOUT')
Review Comment:
Is this an intentional change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
