Abacn commented on PR #31838:
URL: https://github.com/apache/beam/pull/31838#issuecomment-2221860746
Checkout this PR, removed excludeCategory in commonRunnerV2ExcludeCategories
and ran `./gradlew :runners:google-cloud-dataflow-java:validatesRunnerV2Test
--tests *test*StringSetMetrics` manually, still get the same AssertionError
```
org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests
java.lang.AssertionError:
Expected: iterable with items
[MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sources", step="MyStep1", attempted=<StringSetResult{stringSet=[gcs]}>},
MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sinks", step="MyStep2", attempted=<StringSetResult{stringSet=[kafka,
bq]}>}, MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sideinputs", step="MyStep1",
attempted=<StringSetResult{stringSet=[bigtable, spanner]}>},
MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sideinputs", step="MyStep2", attempted=<StringSetResult{stringSet=[sql,
bigtable]}>}] in any order
but: no item matches:
MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sources", step="MyStep1", attempted=<StringSetResult{stringSet=[gcs]}>},
MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sinks", step="MyStep2", attempted=<StringSetResult{stringSet=[kafka,
bq]}>}, MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sideinputs", step="MyStep1",
attempted=<StringSetResult{stringSet=[bigtable, spanner]}>},
MetricResult{inNamespace="org.apache.beam.sdk.metrics.MetricsTest",
name="sideinputs", step="MyStep2", attempted=<StringSetResult{stringSet=[sql,
bigtable]}>} in []
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
at
org.apache.beam.sdk.metrics.MetricsTest.assertStringSetMetrics(MetricsTest.java:449)
```
is this expected? (there is still some gap to make this metrics available in
PipelineResult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
