m-trieu commented on code in PR #31784:
URL: https://github.com/apache/beam/pull/31784#discussion_r1674226116
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/refresh/ActiveWorkRefresher.java:
##########
@@ -103,5 +116,35 @@ private void invalidateStuckCommits() {
}
}
- protected abstract void refreshActiveWork();
+ private void refreshActiveWork() {
+ Instant refreshDeadline =
clock.get().minus(Duration.millis(activeWorkRefreshPeriodMillis));
+
+ Map<HeartbeatSender, Heartbeat> fannedOutHeartbeatRequests = new
HashMap<>();
+
+ for (ComputationState computationState : computations.get()) {
+ String computationId = computationState.getComputationId();
+
+ // Get heartbeat requests for computation's current active work,
aggregated by GetDataStream
+ // to correctly fan-out the heartbeat requests.
+ Table<HeartbeatSender, RefreshableWork, HeartbeatRequest> heartbeats =
+ HeartbeatRequests.getRefreshableKeyHeartbeats(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
