KevinGG commented on pull request #12686:
URL: https://github.com/apache/beam/pull/12686#issuecomment-681009272


   > R: @KevinGG
   > 
   > Is pipeline_analyzer safe to remove? Seems no one's referencing it since 
pipeline_instrument came into place.
   
   Yes, it's safe to remove. Because we were using a different approach to 
decide what to cache and what to execute to resolve the 
re-execution/out-of-order execution issues in a REPL environment, we moved away 
from `pipeline_analyzer`.
   
   > 
   > display_manager.py is also not referenced anymore, but I am not sure about 
this one since there are more recent changes to that file.
   
   We can leave it as it is. Though we started using pipeline_graph directly, 
the display manager did provide a great abstraction above the underlying os and 
installed executable dependencies. We could extend it into doing other things 
in the future.
   
   
   Thank you for being diligent and clean up the code base!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to