TheNeuralBit commented on a change in pull request #12682:
URL: https://github.com/apache/beam/pull/12682#discussion_r477466005
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -213,7 +213,14 @@ def update(self, other):
DeferredSeries,
'__i%s__' % base,
frame_base._elementwise_method('__i%s__' % base, inplace=True))
-for name in ['__lt__', '__le__', '__gt__', '__ge__', '__eq__', '__ne__']:
+for name in ['__lt__',
+ '__le__',
+ '__gt__',
+ '__ge__',
+ '__eq__',
+ '__ne__',
+ '__or__',
Review comment:
Moved `or` and `and` so that `__ior__` and `__iand__` get defined
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
