Abacn commented on code in PR #32022:
URL: https://github.com/apache/beam/pull/32022#discussion_r1697209529
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricResultsMatchers.java:
##########
@@ -211,17 +212,21 @@ private static class MatchNameAndKey<T> extends
TypeSafeMatcher<MetricResult<T>>
private final String namespace;
private final String name;
- private final String step;
+ private final @Nullable String step;
Review Comment:
`MetricKey.create` has parameter type `(@Nullable String, MetricName)`. It
already supported null step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
