Polber commented on PR #32008:
URL: https://github.com/apache/beam/pull/32008#issuecomment-2261287259

   @Abacn 
   > If this is meant for DataflowTemplates, we should push for 
[GoogleCloudPlatform/DataflowTemplates#1429](https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1429)
 again...
   
   This is meant as a prerequisite to #31987 which adds ReadFromSpanner to Beam 
YAML. 
   
   It allows schema reads from Spanner without needing to specify a schema file 
which makes using in Beam YAML much more user-friendly and similar to how 
ReadFromBigQuery works.
   
   > Format check error message
   > 
   > ```
   >  Name 'StructTypeWithStruct' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[LocalVariableName]
   > ```
   I can fix format error
   
   > have you been able to find SpannerIO reviewer?
   
   No, I was waiting for checks to pass before finding one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to