lostluck commented on issue #21515: URL: https://github.com/apache/beam/issues/21515#issuecomment-2265929953
The PR is pretty great as is TBH! So the clarify the goal of this issue: The intent is that most of *beam* isn't relying on the deprecated package to function. So the changes you've made a great thus far. However, we do want to ensure that if users are somehow still relying on v1 protocol buffer types that they're using, that they continue to function. This means we need to keep the code in beam/create_test.go and the protov1 handling code in beam/coder.go with some very small changes. I'll add comments to the PR directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
