Abacn commented on code in PR #32068:
URL: https://github.com/apache/beam/pull/32068#discussion_r1702389962
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Lineage.java:
##########
@@ -23,11 +23,8 @@
public class Lineage {
public static final String LINEAGE_NAMESPACE = "lineage";
- public static final String SOURCE_METRIC_NAME = "sources";
Review Comment:
this is breaking change but Lineage is just introduced for one release and
only used internally. I would suggest change the constant String to a enum so
we can have a query method guarantees the metric name is among defined ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
