imvtsl commented on PR #32045:
URL: https://github.com/apache/beam/pull/32045#issuecomment-2266349556
> Similarly, for `create_test.go` the code there is validating that a
ProtoV1 message is supported and can be encoded.
>
Thank you!! I had no idea about protoadapt package. I was trying to modify
tests to somehow work with proto v2 message. This helped clarified the goal of
the test case.
> You can remove the marshal interface lines.
>
> ```
> _ proto.Marshaler = &testProto{}
> _ proto.Unmarshaler = &testProto{}
> ```
>
> Since we aren't relying on the protoV1 unmarshalling handlers after this
PR.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
