Abacn commented on code in PR #32083: URL: https://github.com/apache/beam/pull/32083#discussion_r1704349921
########## sdks/java/build-tools/src/main/resources/beam/checkstyle/checkstyle.xml: ########## @@ -119,6 +119,14 @@ page at http://checkstyle.sourceforge.net/config.html --> <property name="message" value="You are using raw guava, please use vendored guava classes."/> </module> + <!-- Forbid guava Charset. --> Review Comment: tested that the enforcement is effective without source code changes, build fails with ``` > Task :sdks:java:core:checkstyleMain [ant:checkstyle] [ERROR] /Users/yathu/beam/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/providers/LoggingTransformProvider.java:39: You are using guava Charsets, please use Java builtin StandardCharsets. [ForbidGuavaCharset] ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
