bzablocki commented on issue #32107: URL: https://github.com/apache/beam/issues/32107#issuecomment-2275390190
@ppawel Is the 'idleDurationThreshold' the only parameter you'd like to have control over or do you want to be able to override the entire `WatermarkPolicy` object? I can either 1) expose the `withWatermarkIdleDurationThreshold()` configuration to the `SolaceIO.read().withWatermarkIdleDurationThreshold()` or 2) expose the `WatermarkPolicy`, where you would have to override the `getWatermark()` and `update()` methods if you'd opt in for your own implementation. You would set it then via `SolaceIO.read().withWatermarkPolicy(...)`. I'm leaning towards ad 1, where the user would have one simple setting to tweak, which seems consistent with other connectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
