robertwb commented on code in PR #32117:
URL: https://github.com/apache/beam/pull/32117#discussion_r1711722268
##########
sdks/python/apache_beam/yaml/yaml_combine.py:
##########
@@ -70,7 +70,7 @@ def normalize_combine(spec):
def normalize_agg(dest, agg):
if isinstance(agg, str):
agg = {'fn': agg}
- if 'value' not in agg and spec.get('language') != 'sql':
+ if 'value' not in agg and config.get('language') != 'sql':
Review Comment:
Nice catch.
##########
website/www/site/content/en/documentation/sdks/yaml-inline-python.md:
##########
@@ -123,6 +123,8 @@ define a `beam.PTransform` inline, e.g.
constructor: __constructor__
kwargs:
source: |
+ import apache_beam as beam
Review Comment:
Beam is explicitly and intentionally in the namespace for convenience:
https://github.com/apache/beam/blob/release-2.41.0/sdks/python/apache_beam/utils/python_callable.py#L105
so imports are superfluous and shouldn't be added. (There aren't any other
"hidden" imports we have to worry about.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
