trucleduc commented on a change in pull request #12661:
URL: https://github.com/apache/beam/pull/12661#discussion_r477650841
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -220,6 +222,21 @@ public static Import importResources(
return new Import(fhirStore, tempDir, deadLetterDir, contentStructure);
}
+ /**
+ * Export resources to GCS. Intended for use on non-empty FHIR stores
+ *
+ * @param fhirStore the fhir store, in the format:
+ *
projects/project_id/locations/location_id/datasets/dataset_id/fhirStores/fhir_store_id
+ * @param exportGcsUriPrefix the destination GCS dir, in the format:
+ * gs://YOUR_BUCKET_NAME/path/to/a/dir
+ * @return the export
+ * @see ExportGcs
+ */
+ public static ExportGcs exportResourcesToGcs(String fhirStore, String
exportGcsUriPrefix) {
+ return new ExportGcs(
+ StaticValueProvider.of(fhirStore),
StaticValueProvider.of(exportGcsUriPrefix));
+ }
Review comment:
Nice. Thanks for catching. We indeed want to use this as a template :-)
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##########
@@ -220,6 +222,21 @@ public static Import importResources(
return new Import(fhirStore, tempDir, deadLetterDir, contentStructure);
}
+ /**
+ * Export resources to GCS. Intended for use on non-empty FHIR stores
+ *
+ * @param fhirStore the fhir store, in the format:
+ *
projects/project_id/locations/location_id/datasets/dataset_id/fhirStores/fhir_store_id
+ * @param exportGcsUriPrefix the destination GCS dir, in the format:
+ * gs://YOUR_BUCKET_NAME/path/to/a/dir
+ * @return the export
+ * @see ExportGcs
+ */
+ public static ExportGcs exportResourcesToGcs(String fhirStore, String
exportGcsUriPrefix) {
+ return new ExportGcs(
+ StaticValueProvider.of(fhirStore),
StaticValueProvider.of(exportGcsUriPrefix));
+ }
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
