damccorm commented on code in PR #32148: URL: https://github.com/apache/beam/pull/32148#discussion_r1713847441
########## gradle/wrapper/gradle-wrapper.properties: ########## @@ -1,3 +1,4 @@ +#Sat Aug 10 17:06:24 IST 2024 Review Comment: Looks like this was added by mistake, could you please remove it? ########## sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/Transport.java: ########## @@ -23,7 +23,7 @@ import com.google.api.client.http.HttpRequestInitializer; import com.google.api.client.http.HttpTransport; import com.google.api.client.json.JsonFactory; -import com.google.api.client.json.jackson2.JacksonFactory; +import com.google.api.client.json.gson.GsonFactory; Review Comment: From the precommits (https://github.com/apache/beam/actions/runs/10342154630/job/28624760220?pr=32148), I see the following error: ``` Execution failed for task ':sdks:java:extensions:google-cloud-platform-core:analyzeClassesDependencies'. > Dependency analysis found issues. usedUndeclaredArtifacts - com.google.http-client:google-http-client-gson:1.44.1@jar unusedDeclaredArtifacts - com.google.http-client:google-http-client-jackson2:1.44.1@jar ``` I think we need to replace the jackson artifact with the gson one here - https://github.com/apache/beam/blob/dd3fa04c90df95dd9998264f007f7b84bb18fe34/sdks/java/extensions/google-cloud-platform-core/build.gradle#L42 (example where we've already included the gson library - https://github.com/apache/beam/blob/780eef98083fe56f81cc5c62dc8ff193993584f0/sdks/java/io/solace/build.gradle#L50 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
