scwhittle commented on code in PR #32044:
URL: https://github.com/apache/beam/pull/32044#discussion_r1714089748
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1278,6 +1299,13 @@ private HandlesSplits.SplitResult
trySplitForWindowObservingTruncateRestriction(
if (currentWindow == null) {
return null;
}
+ // We are requesting a checkpoint but have not yet progressed on the
restriction, skip
+ // request.
+ if (fractionOfRemainder == 0
+ && currentTrackerClaimed != null
Review Comment:
I think that the setting of the atomicboolean object being consulted is
protected by splitLock happensafter ordering. This is the same as
currentTracker synchronization.
AtomicBoolean is used since the restriction tracker observing can happen in
the background but the laziness is ok since the split would be retried and the
real value should be eventually observed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
