kennknowles commented on issue #32159:
URL: https://github.com/apache/beam/issues/32159#issuecomment-2285146885
Yea, he most internally-consistent thing to do is to ignore or disable
`upload_graph` if V2 is used. That'll be more targeted than a null check and
won't mask other errors.
Just to state it for posterity, though you probably already know:
- The intent of `upload_graph` is that we upload the V1 post-translation
Dataflow graph in case it is too big to be inlined in the CreateJob request due
to various service-side limitations.
- With V2 we always upload the portable proto and it is translated on the
service side.
When I say they may be mutually exclusive, I think there is a chance that
some piece of code somewhere looks in the same variable for the uploaded file,
since the mechanism looks the same if you aren't type-conscious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
